chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc - Issue 1492073003: Handle more scale factors for extension Browser Action icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

Issue 1492073003: Handle more scale factors for extension Browser Action icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test catches real bug! Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/extension_action_view_controller.cc ('k') | chrome/common/extensions/api/extension_action/action_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

diff --git a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

index 5fee7a65d0c8aa07778af9dc40e60c49d33dd443..c0be1c9b096539cac166895ca007fedd13045392 100644

--- a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

+++ b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

@@ -21,8 +21,8 @@ void PageActionWithBadgeView::GetAccessibleState(

}

gfx::Size PageActionWithBadgeView::GetPreferredSize() const {

- return gfx::Size(ExtensionAction::kPageActionIconMaxSize,

- ExtensionAction::kPageActionIconMaxSize);

+ return gfx::Size(ExtensionAction::ActionIconSize(),

+ ExtensionAction::ActionIconSize());

}

void PageActionWithBadgeView::UpdateVisibility(content::WebContents* contents) {