Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3846)

Unified Diff: chrome/browser/extensions/extension_action_manager_unittest.cc

Issue 1492073003: Handle more scale factors for extension Browser Action icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: better docs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action_manager_unittest.cc
diff --git a/chrome/browser/extensions/extension_action_manager_unittest.cc b/chrome/browser/extensions/extension_action_manager_unittest.cc
index b29328e05a87d6166145aa67c33a1140452fcc5c..d040762d37393d54ca1abbaa935dc2706c9cc0fe 100644
--- a/chrome/browser/extensions/extension_action_manager_unittest.cc
+++ b/chrome/browser/extensions/extension_action_manager_unittest.cc
@@ -98,9 +98,9 @@ bool ExtensionActionManagerTest::IconsMatch(const Extension& extension,
const ExtensionAction& action,
int action_key) {
return action.default_icon()->Get(action_key,
- ExtensionIconSet::MATCH_EXACTLY) ==
- IconsInfo::GetIcons(&extension).Get(extension_key,
- ExtensionIconSet::MATCH_EXACTLY);
+ ExtensionIconSet::MATCH_BIGGER) ==
+ IconsInfo::GetIcons(&extension)
+ .Get(extension_key, ExtensionIconSet::MATCH_EXACTLY);
}
ExtensionAction* ExtensionActionManagerTest::GetAction(
@@ -127,7 +127,7 @@ void ExtensionActionManagerTest::TestPopulateMissingValues(
ASSERT_TRUE(action);
ASSERT_TRUE(TitlesMatch(*extension.get(), *action));
- ASSERT_TRUE(IconsMatch(*extension.get(), 128, *action, 38));
+ ASSERT_TRUE(IconsMatch(*extension.get(), 48, *action, 38));
// Test that the action's missing default_icons are not replaced with smaller
// icons.

Powered by Google App Engine
This is Rietveld 408576698