Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: extensions/common/manifest_handler_helpers.h

Issue 1492073003: Handle more scale factors for extension Browser Action icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test catches real bug! Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/common/constants.cc ('k') | extensions/common/manifest_handler_helpers.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_MANIFEST_HANDLER_HELPERS_H_ 5 #ifndef EXTENSIONS_COMMON_MANIFEST_HANDLER_HELPERS_H_
6 #define EXTENSIONS_COMMON_MANIFEST_HANDLER_HELPERS_H_ 6 #define EXTENSIONS_COMMON_MANIFEST_HANDLER_HELPERS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 15 matching lines...) Expand all
26 // Loads icon paths defined in dictionary |icons_value| into ExtensionIconSet 26 // Loads icon paths defined in dictionary |icons_value| into ExtensionIconSet
27 // |icons|. |icons_value| is a dictionary value {icon size -> icon path}. Icons 27 // |icons|. |icons_value| is a dictionary value {icon size -> icon path}. Icons
28 // in |icons_value| whose size is not in |icon_sizes| will be ignored. 28 // in |icons_value| whose size is not in |icon_sizes| will be ignored.
29 // Returns success. If load fails, |error| will be set. 29 // Returns success. If load fails, |error| will be set.
30 bool LoadIconsFromDictionary(const base::DictionaryValue* icons_value, 30 bool LoadIconsFromDictionary(const base::DictionaryValue* icons_value,
31 const int* icon_sizes, 31 const int* icon_sizes,
32 size_t num_icon_sizes, 32 size_t num_icon_sizes,
33 ExtensionIconSet* icons, 33 ExtensionIconSet* icons,
34 base::string16* error); 34 base::string16* error);
35 35
36 // As above, but loads all icons in |icons_value|.
37 bool LoadAllIconsFromDictionary(const base::DictionaryValue* icons_value,
38 ExtensionIconSet* icons,
39 base::string16* error);
40
36 } // namespace manifest_handler_helpers 41 } // namespace manifest_handler_helpers
37 } // namespace extensions 42 } // namespace extensions
38 43
39 #endif // EXTENSIONS_COMMON_MANIFEST_HANDLER_HELPERS_H_ 44 #endif // EXTENSIONS_COMMON_MANIFEST_HANDLER_HELPERS_H_
OLDNEW
« no previous file with comments | « extensions/common/constants.cc ('k') | extensions/common/manifest_handler_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698