Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Side by Side Diff: extensions/common/manifest_handler_helpers.cc

Issue 1492073003: Handle more scale factors for extension Browser Action icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test catches real bug! Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/common/manifest_handler_helpers.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/manifest_handler_helpers.h" 5 #include "extensions/common/manifest_handler_helpers.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 errors::kInvalidIconPath, key); 52 errors::kInvalidIconPath, key);
53 return false; 53 return false;
54 } 54 }
55 55
56 icons->Add(icon_sizes[i], icon_path); 56 icons->Add(icon_sizes[i], icon_path);
57 } 57 }
58 } 58 }
59 return true; 59 return true;
60 } 60 }
61 61
62 bool LoadAllIconsFromDictionary(const base::DictionaryValue* icons_value,
63 ExtensionIconSet* icons,
64 base::string16* error) {
65 DCHECK(icons);
66 for (base::DictionaryValue::Iterator iterator(*icons_value);
67 !iterator.IsAtEnd(); iterator.Advance()) {
68 int size = 0;
69 std::string icon_path;
70 if (!base::StringToInt(iterator.key(), &size) ||
71 !iterator.value().GetAsString(&icon_path) ||
72 !NormalizeAndValidatePath(&icon_path)) {
73 *error = ErrorUtils::FormatErrorMessageUTF16(errors::kInvalidIconPath,
74 iterator.key());
75 return false;
76 }
77
78 icons->Add(size, icon_path);
79 }
80 return true;
81 }
82
62 } // namespace manifest_handler_helpers 83 } // namespace manifest_handler_helpers
63 84
64 } // namespace extensions 85 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/common/manifest_handler_helpers.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698