Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1492053005: Don't return early in case force-local-builds is passed. (Closed)

Created:
5 years ago by Adrian Kuegel
Modified:
5 years ago
Reviewers:
Nico
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't return early in case force-local-builds is passed. BUG= TBR=thakis@chromium.org NOTRY=true Committed: https://crrev.com/6627bb2f97e34b02b708f68236118abcccf51de6 Cr-Commit-Position: refs/heads/master@{#362955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Adrian Kuegel
Nico, I TBR this change, because I need to fix the Codesearch bots as soon ...
5 years ago (2015-12-03 11:27:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492053005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492053005/1
5 years ago (2015-12-03 11:28:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 11:34:37 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6627bb2f97e34b02b708f68236118abcccf51de6 Cr-Commit-Position: refs/heads/master@{#362955}
5 years ago (2015-12-03 11:36:10 UTC) #10
Nico
lgtm, thanks! This matches what update.sh used to do: # Check if there's anything to ...
5 years ago (2015-12-03 19:45:26 UTC) #11
Nico
5 years ago (2015-12-03 19:46:10 UTC) #12
Message was sent while issue was closed.
(you could've said BUG=494442)

Powered by Google App Engine
This is Rietveld 408576698