Issue 1492053004: Issue 25095. Add 'Change X to Y type annotation' Quick Fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1492053004: Issue 25095. Add 'Change X to Y type annotation' Quick Fix. (Closed)

Created:
5 years ago by scheglov

Modified:
5 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Issue 25095. Add 'Change X to Y type annotation' Quick Fix. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/25095 Committed: https://github.com/dart-lang/sdk/commit/5f49df16445a8affe539ee9e614eafad1d82e7c1

Patch Set 2 : Additional test. #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -0 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/fix.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View		2 chunks	+26 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/fix_test.dart	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1492053004/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/1492053004/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode637 pkg/analysis_server/test/services/correction/fix_test.dart:637: } Perhaps also f(String s) { s = ...

5 years ago (2015-12-03 01:48:13 UTC) #2

scheglov

5 years ago (2015-12-03 02:50:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5f49df16445a8affe539ee9e614eafad1d82e7c1 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1492053004: Issue 25095. Add 'Change X to Y type annotation' Quick Fix. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Additional test. #

Messages