Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1491943004: Fix ODR violation. (Closed)

Created:
5 years ago by dogben
Modified:
5 years ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix ODR violation. src/ports/SkFontMgr_fontconfig.cpp and src/fonts/SkFontMgr_fontconfig.cpp both define SkFontMgr_fontconfig. BUG=skia: TBR=bungeman Committed: https://skia.googlesource.com/skia/+/404816ee3ff32a9f0a4fb50329321647cee4b1a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M BUILD.public View 1 chunk +1 line, -0 lines 0 comments Download
M tools/BUILD.public.expected View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491943004/1
5 years ago (2015-12-03 12:52:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/404816ee3ff32a9f0a4fb50329321647cee4b1a5
5 years ago (2015-12-03 13:04:07 UTC) #5
dogben
5 years ago (2015-12-03 13:05:28 UTC) #7
bungeman-skia
5 years ago (2015-12-03 15:06:09 UTC) #8
Message was sent while issue was closed. 
lgtm, yeah, you should only have one or the other of these files. It's very
silly that the one in src/fonts is named the way it is.

Powered by Google App Engine
This is Rietveld 408576698