Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1491933003: Bring in the latest version of pub. (Closed)

Created:
5 years ago by nweiz
Modified:
5 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, scheglov
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M CHANGELOG.md View 1 1 chunk +27 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
nweiz
5 years ago (2015-12-02 20:44:59 UTC) #2
Bob Nystrom
lgtm https://codereview.chromium.org/1491933003/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1491933003/diff/1/CHANGELOG.md#newcode32 CHANGELOG.md:32: * `pub serve` now serves GZIPs the assets ...
5 years ago (2015-12-02 22:02:02 UTC) #3
nweiz
Code review changes
5 years ago (2015-12-02 22:03:40 UTC) #4
nweiz
https://codereview.chromium.org/1491933003/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1491933003/diff/1/CHANGELOG.md#newcode32 CHANGELOG.md:32: * `pub serve` now serves GZIPs the assets it ...
5 years ago (2015-12-02 22:03:46 UTC) #5
nweiz
5 years ago (2015-12-02 22:06:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
85dc0454b370f1bb0fd69e46245397b1fe900601 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698