Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149193002: Apply automatic range checking for enums across p2p_messages IPC. (Closed)

Created:
6 years, 10 months ago by Tom Sepez
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Visibility:
Public.

Description

Apply automatic range checking for enums across p2p_messages IPC. This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M content/common/p2p_messages.h View 1 chunk +7 lines, -3 lines 0 comments Download
M content/public/common/p2p_socket_type.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/net_util.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Tom Sepez
+ttuttle, joi for owners review.
6 years, 10 months ago (2014-01-28 22:07:32 UTC) #1
Deprecated (see juliatuttle)
On 2014/01/28 22:07:32, Tom Sepez wrote: > +ttuttle, joi for owners review. lgtm.
6 years, 10 months ago (2014-01-28 22:21:36 UTC) #2
Jói
//content/public LGTM.
6 years, 10 months ago (2014-01-29 10:50:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/149193002/1
6 years, 10 months ago (2014-01-29 17:55:59 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=218039
6 years, 10 months ago (2014-01-29 18:41:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/149193002/1
6 years, 10 months ago (2014-01-29 20:25:24 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 00:59:39 UTC) #7
Message was sent while issue was closed. 
Change committed as 247791

Powered by Google App Engine
This is Rietveld 408576698