Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1491923003: Improve rendering of callsite with non-function target. (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Improve rendering of callsite with non-function target. This hackily disambiguates multiple calls for the iterator protocols in ForOf / Yield* by adding -2 / -1 to the pos. BUG=v8:3953 LOG=y Committed: https://crrev.com/a6ed24d61c597c0e78d2d1c830d86ce33e091531 Cr-Commit-Position: refs/heads/master@{#32527}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -40 lines) Patch
M src/ast/prettyprinter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ast/prettyprinter.cc View 9 chunks +38 lines, -15 lines 0 comments Download
M src/parsing/parser.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/parsing/parser.cc View 1 2 chunks +9 lines, -5 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/preparser.h View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +29 lines, -3 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-stepnext-for.js View 1 2 2 chunks +9 lines, -6 lines 0 comments Download
M test/webkit/fast/js/toString-overrides-expected.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/run-json-stringify-expected.txt View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Toon Verwaest
ptal
5 years ago (2015-12-02 17:13:37 UTC) #2
Camillo Bruni
lgtm https://codereview.chromium.org/1491923003/diff/40001/src/runtime/runtime-internal.cc File src/runtime/runtime-internal.cc (right): https://codereview.chromium.org/1491923003/diff/40001/src/runtime/runtime-internal.cc#newcode417 src/runtime/runtime-internal.cc:417: if (!it.done()) { early return!
5 years ago (2015-12-02 17:33:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491923003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491923003/40001
5 years ago (2015-12-02 17:42:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/7286)
5 years ago (2015-12-02 17:53:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491923003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491923003/60001
5 years ago (2015-12-02 18:16:18 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-02 18:36:44 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-02 18:37:34 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a6ed24d61c597c0e78d2d1c830d86ce33e091531
Cr-Commit-Position: refs/heads/master@{#32527}

Powered by Google App Engine
This is Rietveld 408576698