Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1491903002: [turbofan] Refactor escape analysis to only expose one class. (Closed)

Created:
5 years ago by sigurds
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Refactor escape analysis to only expose one class. R=mstarzinger@chromium.org BUG=v8:4586 LOG=n Committed: https://crrev.com/6095d0af307a8b977c262315d2e9dcd2fa769b05 Cr-Commit-Position: refs/heads/master@{#32523}

Patch Set 1 #

Patch Set 2 : Ensure only EscapeAnalysis can create EscapeStatusAnalysis #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -90 lines) Patch
M src/compiler/escape-analysis.h View 1 5 chunks +15 lines, -9 lines 0 comments Download
M src/compiler/escape-analysis.cc View 16 chunks +66 lines, -41 lines 0 comments Download
M src/compiler/escape-analysis-reducer.h View 2 chunks +3 lines, -6 lines 0 comments Download
M src/compiler/escape-analysis-reducer.cc View 6 chunks +9 lines, -10 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M test/unittests/compiler/escape-analysis-unittest.cc View 1 5 chunks +11 lines, -17 lines 0 comments Download

Dependent Patchsets:

Issue 1485183002 Patch 20001
Issue 1485183002 Patch 40001

Messages

Total messages: 7 (2 generated)
sigurds
PTAL
5 years ago (2015-12-02 12:12:16 UTC) #1
Michael Starzinger
LGTM.
5 years ago (2015-12-02 15:01:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491903002/20001
5 years ago (2015-12-02 15:10:03 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 15:20:35 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-02 15:21:29 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6095d0af307a8b977c262315d2e9dcd2fa769b05
Cr-Commit-Position: refs/heads/master@{#32523}

Powered by Google App Engine
This is Rietveld 408576698