components/plugins/renderer/loadable_plugin_placeholder.h - Issue 1491893004: Plugin Power Saver: Remove Size Recheck hack in plugin placeholders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.h

Issue 1491893004: Plugin Power Saver: Remove Size Recheck hack in plugin placeholders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0047-pps-skip-poster-for-same-origin

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/plugins/renderer/loadable_plugin_placeholder.cc » ('j') | components/plugins/renderer/loadable_plugin_placeholder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/plugins/renderer/loadable_plugin_placeholder.h

diff --git a/components/plugins/renderer/loadable_plugin_placeholder.h b/components/plugins/renderer/loadable_plugin_placeholder.h

index 6cd4ad8b81eef96152fc2181f78b63fa5be283fb..417db5fa7c1e583cf257da0828710d6cc2f4a653 100644

--- a/components/plugins/renderer/loadable_plugin_placeholder.h

+++ b/components/plugins/renderer/loadable_plugin_placeholder.h

@@ -87,7 +87,6 @@ class LoadablePluginPlaceholder : public PluginPlaceholderBase {

void UpdateMessage();

bool LoadingBlocked() const;

- void RecheckSizeAndMaybeUnthrottle();

// Plugin creation is embedder-specific.

virtual blink::WebPlugin* CreatePlugin() = 0;

@@ -119,10 +118,7 @@ class LoadablePluginPlaceholder : public PluginPlaceholderBase {

bool finished_loading_;

std::string identifier_;

- // Used to prevent re-entrancy during the size recheck for throttled plugins.

- bool in_size_recheck_;

gfx::Rect unobscured_rect_;

- base::OneShotTimer size_update_timer_;

// True if the power saver heuristic has already been run on this content.

bool heuristic_run_before_;

« no previous file with comments | « no previous file | components/plugins/renderer/loadable_plugin_placeholder.cc » ('j') | components/plugins/renderer/loadable_plugin_placeholder.cc » ('J')