Plugin Power Saver: Remove Size Recheck hack in plugin placeholders.

Plugin Power Saver: Remove Size Recheck hack in plugin placeholders.

See https://code.google.com/p/chromium/issues/detail?id=343769.

The Blink faulty geometry is _almost_ fixed, and it seems fixed-enough
to remove the (awful) size recheck hack for plugin placeholders.

As a nice side effect, removing this size recheck hack will also make
essential plugins with posters no longer have an ugly delay.

BUG=497429, 560590
Committed: https://crrev.com/f74fd9e11c465ff68c954cc30a1856300a9c54be
Cr-Commit-Position: refs/heads/master@{#372674}

[tommycli, 2015-12-03 01:12:56]

Description was changed from

==========
Plugin Power Saver: Remove Size Recheck hack in plugin placeholders.

See https://code.google.com/p/chromium/issues/detail?id=343769.

The Blink faulty geometry is _almost_ fixed, and it seems fixed-enough
to remove the (awful) size recheck hack for plugin placeholders.

BUG=497429
==========

to

==========
Plugin Power Saver: Remove Size Recheck hack in plugin placeholders.

See https://code.google.com/p/chromium/issues/detail?id=343769.

The Blink faulty geometry is _almost_ fixed, and it seems fixed-enough
to remove the (awful) size recheck hack for plugin placeholders.

As a nice side effect, removing this size recheck hack will also make
essential plugins with posters no longer have an ugly delay.

BUG=497429,560590
==========

[tommycli, 2015-12-03 01:12:56]

tommycli@chromium.org changed reviewers:
+ groby@chromium.org

[tommycli, 2015-12-11 21:59:25]

Patchset #4 (id:60001) has been deleted

[tommycli, 2015-12-11 22:25:21]

groby: PTAL, this should fix the perceived "delay" with the large plugins with
posters.

The recheck business is just not needed anymore (from my personal testing).

[groby-ooo-7-16, 2015-12-15 01:28:13]

https://codereview.chromium.org/1491893004/diff/40001/components/plugins/rend...
File components/plugins/renderer/loadable_plugin_placeholder.cc (left):

https://codereview.chromium.org/1491893004/diff/40001/components/plugins/rend...
components/plugins/renderer/loadable_plugin_placeholder.cc:39: // Blink can
report incorrect sizes to plugins while the compositing state is
Do we not have the "incorrect sizes" issue any more? Just because it's not
reproing on your machine... :)

Did we have a test case/page for this?

[tommycli, 2015-12-15 02:09:23]

groby: thanks!

https://codereview.chromium.org/1491893004/diff/40001/components/plugins/rend...
File components/plugins/renderer/loadable_plugin_placeholder.cc (left):

https://codereview.chromium.org/1491893004/diff/40001/components/plugins/rend...
components/plugins/renderer/loadable_plugin_placeholder.cc:39: // Blink can
report incorrect sizes to plugins while the compositing state is
On 2015/12/15 01:28:13, groby wrote:
> Do we not have the "incorrect sizes" issue any more? Just because it's not
> reproing on your machine... :)
> 
> Did we have a test case/page for this?

The incorrect size report bug has been mostly, but not completely, fixed:
https://code.google.com/p/chromium/issues/detail?id=343769

Most of the cases with incorrect size reports have been eliminated because of
https://codereview.chromium.org/1413523007/

The remaining cases I've filed as a bug here, and don't affect the PPS use case.
https://code.google.com/p/chromium/issues/detail?id=569172

I'm not 100% sure about the above. There are two browser tests that should start
heavily flaking if I'm wrong:

PluginPowerSaverBrowserTest.LargeCrossOriginObscured
PluginPowerSaverBrowserTest.PosterTests

But yes, I've mostly only tested on my local machine so far.

[groby-ooo-7-16, 2015-12-15 18:11:40]

And look, LargeCrossOriginObscured failed on the try bots :)

We might need to retest from time to time :(

[tommycli, 2015-12-15 18:47:58]

On 2015/12/15 18:11:40, groby wrote:
> And look, LargeCrossOriginObscured failed on the try bots :)
> 
> We might need to retest from time to time :(

Dang... I didn't see that.

I'll revisit this after I get the preceding patch relanded:
https://codereview.chromium.org/1522173002/

It would be a great thing if this worked. It would remove the visible lag for
large cross origin posters and resize-unthrottles.

[groby-ooo-7-16, 2016-01-04 18:51:49]

Where are we on this?

[tommycli, 2016-01-04 18:55:24]

On 2016/01/04 18:51:49, groby wrote:
> Where are we on this?

Since this relanded: https://codereview.chromium.org/1522173002/

I will be re-investigating to see if this is landable.

[tommycli, 2016-01-04 22:17:41]

groby: I think this is okay.

The tests are flaky. But I think it's flaky unrelated to this patch. See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

If the flakiness increases after this patch, we can revert?

Alternatively, we can delay committing this until after we fix the flakiness,
but I'll vote for the break-things-then-revert approach.

[groby-ooo-7-16, 2016-01-26 02:32:32]

On 2016/01/04 22:17:41, tommycli wrote:
> groby: I think this is okay.
> 
> The tests are flaky. But I think it's flaky unrelated to this patch. See
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
> 
> If the flakiness increases after this patch, we can revert?
> 
> Alternatively, we can delay committing this until after we fix the flakiness,
> but I'll vote for the break-things-then-revert approach.

Since it's OK, I'm OK as well. Provided you keep a close eye on flakiness, and
revert if there's any increase. LGTM

[tommycli, 2016-02-01 16:03:02]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-02-01 16:05:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491893004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491893004/100001

[commit-bot: I haz the power, 2016-02-01 16:47:37]

Description was changed from

==========
Plugin Power Saver: Remove Size Recheck hack in plugin placeholders.

See https://code.google.com/p/chromium/issues/detail?id=343769.

The Blink faulty geometry is _almost_ fixed, and it seems fixed-enough
to remove the (awful) size recheck hack for plugin placeholders.

As a nice side effect, removing this size recheck hack will also make
essential plugins with posters no longer have an ugly delay.

BUG=497429,560590
==========

to

==========
Plugin Power Saver: Remove Size Recheck hack in plugin placeholders.

See https://code.google.com/p/chromium/issues/detail?id=343769.

The Blink faulty geometry is _almost_ fixed, and it seems fixed-enough
to remove the (awful) size recheck hack for plugin placeholders.

As a nice side effect, removing this size recheck hack will also make
essential plugins with posters no longer have an ugly delay.

BUG=497429,560590
==========

[commit-bot: I haz the power, 2016-02-01 16:47:38]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-02-01 16:49:02]

Description was changed from

==========
Plugin Power Saver: Remove Size Recheck hack in plugin placeholders.

See https://code.google.com/p/chromium/issues/detail?id=343769.

The Blink faulty geometry is _almost_ fixed, and it seems fixed-enough
to remove the (awful) size recheck hack for plugin placeholders.

As a nice side effect, removing this size recheck hack will also make
essential plugins with posters no longer have an ugly delay.

BUG=497429,560590
==========

to

==========
Plugin Power Saver: Remove Size Recheck hack in plugin placeholders.

See https://code.google.com/p/chromium/issues/detail?id=343769.

The Blink faulty geometry is _almost_ fixed, and it seems fixed-enough
to remove the (awful) size recheck hack for plugin placeholders.

As a nice side effect, removing this size recheck hack will also make
essential plugins with posters no longer have an ugly delay.

BUG=497429,560590

Committed: https://crrev.com/f74fd9e11c465ff68c954cc30a1856300a9c54be
Cr-Commit-Position: refs/heads/master@{#372674}
==========

[commit-bot: I haz the power, 2016-02-01 16:49:03]

Patchset 5 (id:??) landed as
https://crrev.com/f74fd9e11c465ff68c954cc30a1856300a9c54be
Cr-Commit-Position: refs/heads/master@{#372674}

[Will Harris, 2016-02-25 21:45:19]

A revert of this CL (patchset #5 id:100001) has been created in
https://codereview.chromium.org/1732313003/ by wfh@chromium.org.

The reason for reverting is: this is causing RELEASE_ASSERT crashes, see bug
545039.