Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Issue 1491863002: [proxies] Adapt and reenable harmony/proxies-for.js test. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Adapt and reenable harmony/proxies-for.js test. R=rossberg BUG=v8:1543 LOG=n Committed: https://crrev.com/384ec6dc92df8ad5dac328195de4866cdff46deb Cr-Commit-Position: refs/heads/master@{#32579}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -48 lines) Patch
M test/mjsunit/harmony/proxies-for.js View 1 5 chunks +10 lines, -47 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
neis
5 years ago (2015-12-02 08:27:33 UTC) #1
rossberg
lgtm https://codereview.chromium.org/1491863002/diff/1/test/mjsunit/harmony/proxies-for.js File test/mjsunit/harmony/proxies-for.js (right): https://codereview.chromium.org/1491863002/diff/1/test/mjsunit/harmony/proxies-for.js#newcode97 test/mjsunit/harmony/proxies-for.js:97: return k == "0" || k == "a" ...
5 years ago (2015-12-03 14:40:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491863002/20001
5 years ago (2015-12-03 16:28:10 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 17:41:13 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-03 17:41:46 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/384ec6dc92df8ad5dac328195de4866cdff46deb
Cr-Commit-Position: refs/heads/master@{#32579}

Powered by Google App Engine
This is Rietveld 408576698