Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1491843003: X87: [turbofan] Implemented the optional Float32RoundUp operator. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Implemented the optional Float32RoundUp operator. port 4f4947898d3a5c23b5545aed195e97295a64e18b (r32262) original commit message: The Float32RoundUp operator rounds float32 numbers towards infinity. The operator is currently implemented on x64, ia32, arm, and arm64. BUG= Committed: https://crrev.com/7d6c566622e95ce4e58aebd84d5c0da03d65d9ed Cr-Commit-Position: refs/heads/master@{#32515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
zhengxing.li
5 years ago (2015-12-02 08:18:05 UTC) #2
ahaas
lgtm
5 years ago (2015-12-02 08:42:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491843003/1
5 years ago (2015-12-02 09:18:48 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-02 09:18:50 UTC) #7
Weiliang
lgtm
5 years ago (2015-12-02 13:22:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491843003/1
5 years ago (2015-12-02 13:22:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 14:05:48 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-02 14:06:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d6c566622e95ce4e58aebd84d5c0da03d65d9ed
Cr-Commit-Position: refs/heads/master@{#32515}

Powered by Google App Engine
This is Rietveld 408576698