Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3636)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java

Issue 1491793002: Add histograms for ExternalDataUseObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/data_usage/external_data_use_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java
index 141623adf039107b46b18846423471283744329f..ffb3a39281fa41037a14966acc383c49e4bbbabb 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java
@@ -88,8 +88,10 @@ public class ExternalDataUseObserver {
* @param bytesDownloaded number of bytes downloaded by Chromium.
* @param bytesUploaded number of bytes uploaded by Chromium.
* The result of this request is returned asynchronously via
- * {@link #nativeOnReportDataUseDone}. A new report should be submitted only after the
- * result has been returned via {@link #nativeOnReportDataUseDone}.
+ * {@link #nativeOnReportDataUseDone}. A new report should preferably be submitted only after
+ * the result of the previous report has been returned via {@link #nativeOnReportDataUseDone}.
+ * Submitting another data use report while the previous is pending may cause the previous
+ * report to be lost.
*/
@CalledByNative
protected void reportDataUse(String label, int networkType, String mccMnc,
« no previous file with comments | « no previous file | chrome/browser/android/data_usage/external_data_use_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698