Chromium Code Reviews Chromium Code Reviews
Issue 1491793002:
Add histograms for ExternalDataUseObserver (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 524e9c03947469e6e8e3c5dc9350bb22b79dc6d8..7c8eeabe6a7d4267b6da660739078223e6da0048 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -6423,6 +6423,57 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="DataUsage.ReportSubmission.Failed.Bytes" units="bytes"> |
| + <owner>bengr@chromium.org</owner> |
| + <owner>tbansal@chromium.org</owner> |
| + <summary> |
| + Count of bytes in the data use reports that whose submission to the external |
| + data use observer failed. Recorded everytime submission of data use report |
| + fails. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DataUsage.ReportSubmission.Lost.Bytes" units="bytes"> |
| + <owner>bengr@chromium.org</owner> |
| + <owner>tbansal@chromium.org</owner> |
| + <summary> |
| + Count of bytes in the data use reports that were lost before submission to |
| + the external data use observer timed out. Recorded everytime a report is |
|
sclittle
2015/12/02 19:07:55
nit: confusing wording here, what does this actual
tbansal1
2015/12/03 03:19:45
Rephrased.
|
| + lost before an attempt is made to submit it to the external data use |
| + observer. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DataUsage.ReportSubmission.Successful.Bytes" units="bytes"> |
| + <owner>bengr@chromium.org</owner> |
| + <owner>tbansal@chromium.org</owner> |
| + <summary> |
| + Count of bytes in the data use reports that were successfully submitted to |
| + the external data use observer. Recorded everytime a report is successfully |
| + submitted to the external data use observer. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DataUsage.ReportSubmission.TimedOut.Bytes" units="bytes"> |
| + <owner>bengr@chromium.org</owner> |
| + <owner>tbansal@chromium.org</owner> |
| + <summary> |
| + Count of bytes in the data use reports whose submission to the external data |
| + use observer timed out. Recorded everytime submission of a report to the |
| + external data use observer times out. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DataUsage.ReportSubmissionResult" |
|
sclittle
2015/12/02 19:07:55
nit: Is this histogram necessary? Can't someone ju
tbansal1
2015/12/03 03:19:45
This makes it much easier to analyze.
|
| + enum="DataUsageReportSubmissionResult"> |
| + <owner>bengr@chromium.org</owner> |
| + <owner>tbansal@chromium.org</owner> |
| + <summary> |
| + Result of data usage report submission. Recorded everytime a report is |
|
sclittle
2015/12/02 19:07:55
nit: s/everytime/every time/, here and elsewhere
tbansal1
2015/12/03 03:19:45
Done.
|
| + submitted to the external data use observer. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="DataUse.MessageSize" units="bytes"> |
| <owner>amohammadkhan@chromium.org</owner> |
| <owner>bengr@chromium.org</owner> |
| @@ -58040,6 +58091,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <int value="10" label="Diabled directly from the First Run Experience"/> |
| </enum> |
| +<enum name="DataUsageReportSubmissionResult" type="int"> |
| + <int value="0" label="Successful"/> |
| + <int value="1" label="Failed"/> |
| + <int value="2" label="Timed out"/> |
| + <int value="3" label="Lost"/> |
| +</enum> |
| + |
| <enum name="DataUseServices" type="int"> |
| <int value="0" label="Not Tagged"/> |
| <int value="1" label="Suggestions"/> |
