chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java - Issue 1491793002: Add histograms for ExternalDataUseObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java

Issue 1491793002: Add histograms for ExternalDataUseObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/data_usage/external_data_use_observer.h » ('j') | chrome/browser/android/data_usage/external_data_use_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java

index 141623adf039107b46b18846423471283744329f..e33a012a82288d961b976d70288b5c450d3c84ad 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java

@@ -89,7 +89,8 @@ public class ExternalDataUseObserver {

* @param bytesUploaded number of bytes uploaded by Chromium.

* The result of this request is returned asynchronously via

* {@link #nativeOnReportDataUseDone}. A new report should be submitted only after the

- * result has been returned via {@link #nativeOnReportDataUseDone}.

+ * result has been returned via {@link #nativeOnReportDataUseDone}. Submitting another data

+ * use report while the previous is pending may cause the previous report to be lost.

@CalledByNative

protected void reportDataUse(String label, int networkType, String mccMnc,