Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2686)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java

Issue 1491793002: Add histograms for ExternalDataUseObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed sclittle comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java
index 44b0ab5f2c2f16829cbdbcd81db8831b0928e6ee..e298d986f687d11f0142be661481e981e8db4f39 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java
@@ -88,7 +88,8 @@ public class ExternalDataUseObserver {
* @param bytesUploaded number of bytes uploaded by Chromium.
* The result of this request is returned asynchronously via
* {@link #nativeOnReportDataUseDone}. A new report should be submitted only after the
- * result has been returned via {@link #nativeOnReportDataUseDone}.
+ * result has been returned via {@link #nativeOnReportDataUseDone}. Submitting another data
+ * use report while the previous is pending may cause the previous report to be lost.
sclittle 2015/12/08 02:25:41 This new sentence contradicts the previous sentenc
tbansal1 2015/12/08 04:04:32 There is no concept of canceling a report. Actuall
sclittle 2015/12/09 19:42:59 OK, could you reword/remove the previous sentence,
tbansal1 2015/12/10 00:41:39 Done.
*/
@CalledByNative
protected void reportDataUse(String label, int networkType, String mccMnc,
« no previous file with comments | « no previous file | chrome/browser/android/data_usage/external_data_use_observer.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698