Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1491743010: Reland of [proxies] Make Object.prototype.isPrototypeOf work with proxies. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [proxies] Make Object.prototype.isPrototypeOf work with proxies. (patchset #1 id:1 of https://codereview.chromium.org/1494283002/ ) Reason for revert: Did not help... Original issue's description: > Revert of [proxies] Make Object.prototype.isPrototypeOf work with proxies. (patchset #2 id:20001 of https://codereview.chromium.org/1492863002/ ) > > Reason for revert: > [Sheriff] Speculative revert for: > https://uberchromegw.corp.google.com/i/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3225 > > Can just be relanded if it doesn't get green. > > Original issue's description: > > [proxies] Make Object.prototype.isPrototypeOf step into proxies. > > > > R=rossberg, verwaest@chromium.org > > BUG=v8:1543 > > LOG=n > > > > Committed: https://crrev.com/4ca1180d2e7c409312ae0761cb12843989466573 > > Cr-Commit-Position: refs/heads/master@{#32569} > > TBR=rossberg@chromium.org,verwaest@chromium.org,neis@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:1543 > > Committed: https://crrev.com/48fba9439f291edd5929e19951262dc7e8a09609 > Cr-Commit-Position: refs/heads/master@{#32588} TBR=rossberg@chromium.org,verwaest@chromium.org,neis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1543 Committed: https://crrev.com/2cb40dc722340035c7d4c57449a420a315b0e7e0 Cr-Commit-Position: refs/heads/master@{#32598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -21 lines) Patch
M src/objects.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -7 lines 0 comments Download
M src/prototype.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +12 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M test/mjsunit/harmony/proxies-get-prototype-of.js View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Reland of [proxies] Make Object.prototype.isPrototypeOf work with proxies.
5 years ago (2015-12-04 06:38:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491743010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491743010/1
5 years ago (2015-12-04 06:38:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 06:38:52 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-04 06:39:26 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cb40dc722340035c7d4c57449a420a315b0e7e0
Cr-Commit-Position: refs/heads/master@{#32598}

Powered by Google App Engine
This is Rietveld 408576698