[proxies] Add all-can-read/String/Symbol filtering support to GetKeys()

[proxies] Add all-can-read/String/Symbol filtering support to GetKeys()

Not exposed/used yet, therefore also not testable yet.

Committed: https://crrev.com/186f67085cbfa388b26906aed07bcfd2745b2cc5
Cr-Commit-Position: refs/heads/master@{#32571}

[Jakob Kummerow, 2015-12-03 12:51:44]

jkummerow@chromium.org changed reviewers:
+ cbruni@chromium.org

[Jakob Kummerow, 2015-12-03 12:51:45]

Camillo: PTAL.

Toon: FYI.

Next step is to make Runtime_GetOwnPropertyNames (and its friends) call
JSReceiver::GetKeys().

https://codereview.chromium.org/1491743008/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1491743008/diff/1/src/objects.cc#newcode8109
src/objects.cc:8109: static bool GetKeysFromInterceptor(Isolate* isolate,
This is a refactoring of JSObject::GetKeysForNamedInterceptor and
JSObject::GetKeysForIndexedInterceptor further down in this file, which are both
slated for deletion.

[Camillo Bruni, 2015-12-03 14:32:33]

lgtm

https://codereview.chromium.org/1491743008/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1491743008/diff/1/src/objects.cc#newcode8168
src/objects.cc:8168: /// ...whereas [[OwnPropertyKeys]] shall return whitelisted
properties.
s/\/\/\//\/\//

[Jakob Kummerow, 2015-12-03 14:43:23]

Did that major refactoring you asked for, please take another very thorough look
:-P

https://codereview.chromium.org/1491743008/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1491743008/diff/1/src/objects.cc#newcode8168
src/objects.cc:8168: /// ...whereas [[OwnPropertyKeys]] shall return whitelisted
properties.
On 2015/12/03 14:32:32, cbruni wrote:
> s/\/\/\//\/\// 

Done.

[Jakob Kummerow, 2015-12-03 14:43:30]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2015-12-03 14:43:30]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/1491743008/#ps20001
(title: "critical correctness fix ;-)")

[commit-bot: I haz the power, 2015-12-03 14:43:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491743008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491743008/20001

[commit-bot: I haz the power, 2015-12-03 15:08:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-03 15:08:59]

Description was changed from

==========
[proxies] Add all-can-read/String/Symbol filtering support to GetKeys()

Not exposed/used yet, therefore also not testable yet.
==========

to

==========
[proxies] Add all-can-read/String/Symbol filtering support to GetKeys()

Not exposed/used yet, therefore also not testable yet.

Committed: https://crrev.com/186f67085cbfa388b26906aed07bcfd2745b2cc5
Cr-Commit-Position: refs/heads/master@{#32571}
==========

[commit-bot: I haz the power, 2015-12-03 15:08:59]

Patchset 2 (id:??) landed as
https://crrev.com/186f67085cbfa388b26906aed07bcfd2745b2cc5
Cr-Commit-Position: refs/heads/master@{#32571}