List all child surfaces (including occluded) in CompositorFrame

List all child surfaces (including occluded) in CompositorFrame

Then any occluded child surface with a copy request can be aggregated
(and have its copy done) whenever its parent draws.

BUG=529378
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/afca094c3a1862ebd1440d6b61955a3c25febad3
Cr-Commit-Position: refs/heads/master@{#363877}

[jbauman, 2015-12-02 23:56:36]

Description was changed from

==========
Add reference on surface.

BUG=
==========

to

==========
Add reference on surface.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbauman, 2015-12-03 21:56:50]

Description was changed from

==========
Add reference on surface.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
List all child surfaces (including occluded) in CompositorFrame

Then any occluded child surface with a copy request can be aggregated
(and have its copy done) whenever its parent draws.

BUG=529378
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbauman, 2015-12-07 22:49:07]

jbauman@chromium.org changed reviewers:
+ danakj@chromium.org, kenrb@chromium.org

[jbauman, 2015-12-07 22:49:07]

Almost exactly the same as https://codereview.chromium.org/1430363002/ (but with
a minor fix in the case where a nonexistent frame is referenced).

[kenrb, 2015-12-08 16:10:52]

ipc lgtm

[danakj, 2015-12-08 19:42:44]

LGTM

https://codereview.chromium.org/1491743006/diff/80001/cc/surfaces/surface_agg...
File cc/surfaces/surface_aggregator_unittest.cc (right):

https://codereview.chromium.org/1491743006/diff/80001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator_unittest.cc:534:
frame->metadata.referenced_surfaces.push_back(nonexistent_surface_id);
Can you add a comment somewhere in this test explaining the nonexistent id and
what we're testing with it and where we're actually testing it?

[jbauman, 2015-12-08 23:26:03]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2015-12-08 23:26:03]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
kenrb@chromium.org
Link to the patchset: https://codereview.chromium.org/1491743006/#ps100001
(title: "add comment")

[commit-bot: I haz the power, 2015-12-08 23:36:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491743006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491743006/100001

[commit-bot: I haz the power, 2015-12-09 01:01:25]

Description was changed from

==========
List all child surfaces (including occluded) in CompositorFrame

Then any occluded child surface with a copy request can be aggregated
(and have its copy done) whenever its parent draws.

BUG=529378
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
List all child surfaces (including occluded) in CompositorFrame

Then any occluded child surface with a copy request can be aggregated
(and have its copy done) whenever its parent draws.

BUG=529378
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2015-12-09 01:01:25]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-12-09 01:02:04]

Description was changed from

==========
List all child surfaces (including occluded) in CompositorFrame

Then any occluded child surface with a copy request can be aggregated
(and have its copy done) whenever its parent draws.

BUG=529378
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
List all child surfaces (including occluded) in CompositorFrame

Then any occluded child surface with a copy request can be aggregated
(and have its copy done) whenever its parent draws.

BUG=529378
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/afca094c3a1862ebd1440d6b61955a3c25febad3
Cr-Commit-Position: refs/heads/master@{#363877}
==========

[commit-bot: I haz the power, 2015-12-09 01:02:08]

Patchset 4 (id:??) landed as
https://crrev.com/afca094c3a1862ebd1440d6b61955a3c25febad3
Cr-Commit-Position: refs/heads/master@{#363877}