|
|
Created:
6 years, 10 months ago by Habib Virji Modified:
6 years, 10 months ago Reviewers:
tkent CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Visibility:
Public. |
DescriptionHandling radio group name as case insensitive
Added CaseFoldingHash in the NameToGroupMap to handle group name case
insensitive.
(Replicates patch fixed in WebKit for this issue:
https://bugs.webkit.org/attachment.cgi?id=187180)
Note that some test cases in radio-group-name-case.html fails because
CaseFoldingHash doesn't conform to the specification.
R=tkent
BUG=136105
TEST=automated
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166241
Patch Set 1 #
Total comments: 1
Patch Set 2 : Updated to latest master #
Messages
Total messages: 32 (0 generated)
Replicates patch from webkit@ https://bug-90617-attachments.webkit.org/attachment.cgi?id=187180.
https://codereview.chromium.org/149173007/diff/1/LayoutTests/fast/forms/radio... File LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt (right): https://codereview.chromium.org/149173007/diff/1/LayoutTests/fast/forms/radio... LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt:35: FAIL form.elements[1].checked should be false. Was true. There are some FAIL lines. Are they intentional?
On 2014/01/29 23:28:20, tkent wrote: > https://codereview.chromium.org/149173007/diff/1/LayoutTests/fast/forms/radio... > File LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt (right): > > https://codereview.chromium.org/149173007/diff/1/LayoutTests/fast/forms/radio... > LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt:35: FAIL > form.elements[1].checked should be false. Was true. > There are some FAIL lines. Are they intentional? They are failing and found you consented to it: https://bugs.webkit.org/show_bug.cgi?id=90617#c19. The tests failing are above 8 bits and appears StringHash is not that good in it. Will look into it and update on it.
Updated with latest master changes.
lgtm On 2014/01/30 10:36:18, habib.virji wrote: > The tests failing are above 8 bits and appears StringHash is not that good in > it. Will look into it and update on it. It should be described in a code comment, a test comment, or the CL description. I'll add it to the CL description.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/149173007/20001
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...
CQ bit was unchecked on CL. Ignoring.
CQ bit was unchecked on CL. Ignoring.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/149173007/20001
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...
CQ bit was unchecked on CL. Ignoring.
CQ bit was unchecked on CL. Ignoring.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/149173007/20001
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
CQ bit was unchecked on CL. Ignoring.
CQ bit was unchecked on CL. Ignoring.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/149173007/20001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...
CQ bit was unchecked on CL. Ignoring.
CQ bit was unchecked on CL. Ignoring.
The CQ bit was checked by habib.virji@samsung.com
The CQ bit was unchecked by habib.virji@samsung.com
CQ bit was unchecked on CL. Ignoring.
On 2014/01/31 00:12:03, tkent wrote: > lgtm > > On 2014/01/30 10:36:18, habib.virji wrote: > > The tests failing are above 8 bits and appears StringHash is not that good in > > it. Will look into it and update on it. > > It should be described in a code comment, a test comment, or the CL description. > I'll add it to the CL description. Thanks, was not aware about it. Tests failure does not seem to be related to this CL changes.
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/149173007/20001
Message was sent while issue was closed.
Change committed as 166241
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring. |