Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 149173007: Handling radio group name as case insensitive (Closed)

Created:
6 years, 10 months ago by Habib Virji
Modified:
6 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Handling radio group name as case insensitive Added CaseFoldingHash in the NameToGroupMap to handle group name case insensitive. (Replicates patch fixed in WebKit for this issue: https://bugs.webkit.org/attachment.cgi?id=187180) Note that some test cases in radio-group-name-case.html fails because CaseFoldingHash doesn't conform to the specification. R=tkent BUG=136105 TEST=automated Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166241

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated to latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -1 line) Patch
A LayoutTests/fast/forms/radio/radio-group-name-case.html View 1 chunk +87 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt View 1 chunk +72 lines, -0 lines 0 comments Download
M Source/core/html/forms/CheckedRadioButtons.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (0 generated)
Habib Virji
Replicates patch from webkit@ https://bug-90617-attachments.webkit.org/attachment.cgi?id=187180.
6 years, 10 months ago (2014-01-29 15:04:28 UTC) #1
tkent
https://codereview.chromium.org/149173007/diff/1/LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt File LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt (right): https://codereview.chromium.org/149173007/diff/1/LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt#newcode35 LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt:35: FAIL form.elements[1].checked should be false. Was true. There are ...
6 years, 10 months ago (2014-01-29 23:28:20 UTC) #2
Habib Virji
On 2014/01/29 23:28:20, tkent wrote: > https://codereview.chromium.org/149173007/diff/1/LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt > File LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt (right): > > https://codereview.chromium.org/149173007/diff/1/LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt#newcode35 > ...
6 years, 10 months ago (2014-01-30 10:36:18 UTC) #3
Habib Virji
Updated with latest master changes.
6 years, 10 months ago (2014-01-30 12:21:29 UTC) #4
tkent
lgtm On 2014/01/30 10:36:18, habib.virji wrote: > The tests failing are above 8 bits and ...
6 years, 10 months ago (2014-01-31 00:12:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/149173007/20001
6 years, 10 months ago (2014-01-31 00:14:24 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=24779
6 years, 10 months ago (2014-01-31 03:32:06 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 03:32:10 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 03:32:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/149173007/20001
6 years, 10 months ago (2014-01-31 03:33:01 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=24837
6 years, 10 months ago (2014-01-31 06:21:57 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 06:22:06 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 06:22:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/149173007/20001
6 years, 10 months ago (2014-01-31 06:33:52 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=10202
6 years, 10 months ago (2014-01-31 09:29:04 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 09:29:08 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 09:29:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/149173007/20001
6 years, 10 months ago (2014-01-31 09:35:19 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-01-31 12:43:31 UTC) #19
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=24960
6 years, 10 months ago (2014-01-31 12:43:32 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 12:43:32 UTC) #21
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 12:43:38 UTC) #22
Habib Virji
The CQ bit was checked by habib.virji@samsung.com
6 years, 10 months ago (2014-01-31 17:09:45 UTC) #23
Habib Virji
The CQ bit was unchecked by habib.virji@samsung.com
6 years, 10 months ago (2014-01-31 17:09:48 UTC) #24
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 17:09:58 UTC) #25
Habib Virji
On 2014/01/31 00:12:03, tkent wrote: > lgtm > > On 2014/01/30 10:36:18, habib.virji wrote: > ...
6 years, 10 months ago (2014-01-31 17:14:11 UTC) #26
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 10 months ago (2014-01-31 19:25:19 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/149173007/20001
6 years, 10 months ago (2014-01-31 19:25:25 UTC) #28
commit-bot: I haz the power
Change committed as 166241
6 years, 10 months ago (2014-01-31 20:16:49 UTC) #29
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 20:16:55 UTC) #30
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 20:16:55 UTC) #31
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 20:17:43 UTC) #32
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698