Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 149173004: Adding a dialog which explains that the multi user session has ended because a user policy has chan… (Closed)

Created:
6 years, 10 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 10 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Adding a dialog which explains that the multi user session has ended because a user policy has changed. BUG=314930 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247597

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -63 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/multi_profile_user_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/multi_profile_user_controller_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/multi_profile_user_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.h View 1 chunk +17 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc View 7 chunks +51 lines, -55 lines 2 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
6 years, 10 months ago (2014-01-28 23:31:49 UTC) #1
Dmitry Polukhin
LGTM But please check what happens in user has some page that ask confirmation on ...
6 years, 10 months ago (2014-01-28 23:45:24 UTC) #2
Mr4D (OOO till 08-26)
Thanks for your review! https://codereview.chromium.org/149173004/diff/1/chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc File chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc (right): https://codereview.chromium.org/149173004/diff/1/chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc#newcode90 chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc:90: chrome::AttemptUserExit(); This is only needed ...
6 years, 10 months ago (2014-01-28 23:58:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/149173004/1
6 years, 10 months ago (2014-01-29 00:01:42 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 02:31:41 UTC) #5
Message was sent while issue was closed.
Change committed as 247597

Powered by Google App Engine
This is Rietveld 408576698