Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1491723002: Make CFWL_Custom consistenly named. (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Make CFWL_Custom consistenly named. It's part of the CFWL_*Imp hierarchy, and hence should be named CFWL_CustomImp. CFWL_Custom would belong to a differnt hierarchy according to naming conventions. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8aff2a94aa9603f5fed8a157183db94b43b02a96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M xfa/src/fwl/src/core/fwl_widgetimp.cpp View 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
ochang@ - quick review, naming only. Thanks.
5 years ago (2015-12-01 20:27:05 UTC) #2
Oliver Chang
lgtm
5 years ago (2015-12-01 20:27:41 UTC) #3
Tom Sepez
5 years ago (2015-12-01 20:28:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8aff2a94aa9603f5fed8a157183db94b43b02a96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698