[Courgette] Initial Implementation of LabelManager.

courgette/image_utils.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COURGETTE_IMAGE_UTILS_H_
 #define COURGETTE_IMAGE_UTILS_H_
 
 #include "base/basictypes.h"
 
 // COURGETTE_HISTOGRAM_TARGETS prints out a histogram of how frequently
 // different target addresses are referenced. Purely for debugging.
 #define COURGETTE_HISTOGRAM_TARGETS 0
 
 namespace courgette {
 
 typedef uint32 RVA;
 
+// A Label is a symbolic reference to an address.  Unlike a conventional
+// assembly language, we always know the address.  The address will later be
+// stored in a table and the Label will be replaced with the index into the
+// table.
+//
+// TODO(sra): Make fields private and add setters and getters.

[grt (UTC plus 2), 2015/12/03 15:19:09]

i think you can remove this TODO. based on
https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes, this
should be a struct rather than a class. as such, you could change it to:
struct Label {
  enum : int { kNoIndex = -1 };
  ...
  RVA rva = 0;           // Address referred to by the label.
  ...
};
note the lack of "public:" and trailing underscores on the data member names.

[huangs, 2015/12/03 19:29:06]

I'd rather hold off the "_" suffix change in a mechanical-change-only follow-up,
since this leads to lots of changes in adjustment_method.cc and
adjustment_method_2.cc.  Replaced with TODO for myself.

[grt (UTC plus 2), 2015/12/04 19:33:41]

Acknowledged.

+class Label {
+ public:
+  enum : int { kNoIndex = -1 };
+  explicit Label(RVA rva) : rva_(rva) {}
+
+  bool operator==(const Label& other) const {
+    return rva_ == other.rva_ && index_ == other.index_ &&
+        count_ == other.count_;
+  }
+
+  RVA rva_ = 0;           // Address referred to by the label.
+  int index_ = kNoIndex;  // Index of address in address table.
+  int count_ = 0;
+};
+
 // These helper functions avoid the need for casts in the main code.
 inline uint16 ReadU16(const uint8* address, size_t offset) {
   return *reinterpret_cast<const uint16*>(address + offset);
 }
 
 inline uint32 ReadU32(const uint8* address, size_t offset) {
   return *reinterpret_cast<const uint32*>(address + offset);
 }
 
 inline uint64 ReadU64(const uint8* address, size_t offset) {
   return *reinterpret_cast<const uint64*>(address + offset);
 }
 
 inline uint16 Read16LittleEndian(const void* address) {
   return *reinterpret_cast<const uint16*>(address);
 }
 
 inline uint32 Read32LittleEndian(const void* address) {
   return *reinterpret_cast<const uint32*>(address);
 }
 
 inline uint64 Read64LittleEndian(const void* address) {
   return *reinterpret_cast<const uint64*>(address);
 }
 
 }  // namespace courgette
 
 #endif  // COURGETTE_IMAGE_UTILS_H_