Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Issue 1491653002: Switch canvas.toBlob from idle-periods implementation to threaded implementation to allow experimen… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
index e04ea2b304f96f0bc3e3c80e013ff43918bbac47..831ee6b5e46663aced2ac952526881cfb5042a0f 100644
--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
@@ -561,11 +561,13 @@ void HTMLCanvasElement::toBlob(FileCallback* callback, const String& mimeType, c
RefPtr<DOMUint8ClampedArray> imageDataRef(imageData->data());
RefPtr<CanvasAsyncBlobCreator> asyncCreatorRef = CanvasAsyncBlobCreator::create(imageDataRef.release(), encodingMimeType, imageData->size(), callback);
- if (Platform::current()->isThreadedCompositingEnabled() && (encodingMimeType == DefaultMimeType)) {
- asyncCreatorRef->scheduleAsyncBlobCreation(true);
- } else {
- asyncCreatorRef->scheduleAsyncBlobCreation(false, quality);
- }
+
+// TODO(xlai): After Intent-to-Ship is approved, remove idle-periods version of implementation completely
Justin Novosad 2015/12/01 19:38:02 Create a crbug about this so we don't forget.
+// if (Platform::current()->isThreadedCompositingEnabled() && (encodingMimeType == DefaultMimeType)) {
+ // asyncCreatorRef->scheduleAsyncBlobCreation(true);
+// } else {
Justin Novosad 2015/12/01 19:38:02 Don't commit commented-out code
+ asyncCreatorRef->scheduleAsyncBlobCreation(false, quality);
+// }
}
SecurityOrigin* HTMLCanvasElement::securityOrigin() const
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698