Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1491633002: Allows python line with pylint: disable=line-too-long to have more than 120 chars (Closed)

Created:
5 years ago by nednguyen
Modified:
5 years ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allows python line with pylint: disable=line-too-long to have more than 120 chars. BUG=564100 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M presubmit_canned_checks.py View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
nednguyen
5 years ago (2015-12-01 18:08:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491633002/1
5 years ago (2015-12-01 18:08:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 18:10:49 UTC) #7
aiolos (Not reviewing)
lgtm
5 years ago (2015-12-01 19:45:55 UTC) #8
Dirk Pranke
lgtm
5 years ago (2015-12-01 19:56:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491633002/1
5 years ago (2015-12-01 20:12:41 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-01 20:14:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297765

Powered by Google App Engine
This is Rietveld 408576698