Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 149163005: Work on GN iOS build. (Closed)

Created:
6 years, 10 months ago by brettw
Modified:
6 years, 10 months ago
Reviewers:
msw, Nico
CC:
chromium-reviews, justincohen
Visibility:
Public.

Description

Work on GN iOS build. Separates out some "SDK" related setup on Mac land Linux like we do on Windows. I'm trying to make the "compiler" BUILD file just compiler warnings and CPU options, and have system library stuff on the platform directories. This adds the capability for GN to produce GYP files on Mac that vary according to the GYP generator as well as target-vs-host. I added a bunch of logic to the GN iOS build to set up stuff accordingly based on my current knowledge of what's required. Sadly, this means we now have an 8-way GN build (all combinations of debug/release, host/target, and xcode/ninja). I did some refactoring of the GYP code in GN to make this less unreasonable. I checked that the GYP files look the way I want, but I didn't actually test the resulting builds yet. There is still likely to be some conditions wrong or things not being set properly. I'm going to follow up with a second pass based on actual testing. I believe, however, that with this new GYP generator code in GN, we can express in the .gn files what we need to do the iOS build. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248476

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+457 lines, -149 lines) Patch
M build/config/BUILDCONFIG.gn View 1 2 3 3 chunks +12 lines, -6 lines 0 comments Download
M build/config/compiler/BUILD.gn View 3 chunks +1 line, -18 lines 0 comments Download
A build/config/ios/BUILD.gn View 1 chunk +19 lines, -0 lines 0 comments Download
M build/config/ios/ios_sdk.gni View 1 1 chunk +28 lines, -6 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M build/config/mac/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M build/gyp_chromium View 1 2 3 2 chunks +10 lines, -1 line 0 comments Download
M tools/gn/args.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gn/args.cc View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M tools/gn/command_gyp.cc View 10 chunks +225 lines, -102 lines 0 comments Download
M tools/gn/gyp_binary_target_writer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gn/gyp_binary_target_writer.cc View 5 chunks +80 lines, -8 lines 0 comments Download
M tools/gn/gyp_target_writer.h View 2 chunks +25 lines, -7 lines 0 comments Download
M tools/gn/gyp_target_writer.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
brettw
The GYP files look like this (showing only the leftmost columns for clarity). 'target_name': 're2', ...
6 years, 10 months ago (2014-01-29 05:38:58 UTC) #1
Nico
lgtm :-/ https://codereview.chromium.org/149163005/diff/20001/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/149163005/diff/20001/build/config/BUILDCONFIG.gn#newcode85 build/config/BUILDCONFIG.gn:85: # generator is xcode.On Mac, you can ...
6 years, 10 months ago (2014-01-29 18:34:18 UTC) #2
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 10 months ago (2014-02-03 09:30:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/149163005/240001
6 years, 10 months ago (2014-02-03 09:30:15 UTC) #4
commit-bot: I haz the power
Change committed as 248476
6 years, 10 months ago (2014-02-03 12:04:35 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 12:04:35 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 12:04:43 UTC) #7
msw
Could this be related to a recent iOS runhooks failure? http://build.chromium.org/p/chromium.mac/builders/iOS%20Device/builds/16407 Error: Command /Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python src/build/gyp_chromium ...
6 years, 10 months ago (2014-02-03 20:36:26 UTC) #8
msw
On 2014/02/03 20:36:26, msw wrote: > Could this be related to a recent iOS runhooks ...
6 years, 10 months ago (2014-02-03 21:48:43 UTC) #9
brettw
6 years, 10 months ago (2014-02-04 03:59:11 UTC) #10
Message was sent while issue was closed.
It's not obvious why this code would fail. The script is very simple and just
forwards through to "xcodebuild". I'm going to ignore this for now unless it
pops up again.

Powered by Google App Engine
This is Rietveld 408576698