Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 149163004: Use LOG_IF instead of LOG_IF_FIRST_N in a few places, as per avd's (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index 5ce6608b1dab01823ed78382bcad41f036cf8367..9d641310937266e9aa182931f6ac127d806bd580 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -316,15 +316,11 @@ void QuicSentPacketManager::MarkForRetransmission(
TransmissionType transmission_type) {
TransmissionInfo* transmission_info =
FindOrNull(unacked_packets_, sequence_number);
- if (transmission_info == NULL) {
- LOG(DFATAL) << "transmission_info == NULL";
+ if (transmission_info != NULL) {
+ LOG_IF(DFATAL, transmission_info->retransmittable_frames == NULL);
+ LOG_IF(DFATAL, transmission_info->sent_time == QuicTime::Zero());
} else {
- if (transmission_info->retransmittable_frames == NULL) {
- LOG(DFATAL) << "transmission_info->retransmittable_frames == NULL";
- }
- if (transmission_info->sent_time == QuicTime::Zero()) {
- LOG(DFATAL) << "transmission_info->sent_time == QuicTime::Zero()";
- }
+ LOG(DFATAL) << "Unable to retansmit packet: " << sequence_number;
}
// TODO(ianswett): Currently the RTO can fire while there are pending NACK
// retransmissions for the same data, which is not ideal.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698