Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1491613002: [runtime] Rename IsPropertyEnumerable to PropertyIsEnumerable conforming to the spec. (Closed)

Created:
5 years ago by Camillo Bruni
Modified:
5 years ago
Reviewers:
neis, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Rename IsPropertyEnumerable to PropertyIsEnumerable conforming to the spec. BUG= Committed: https://crrev.com/535e221d4fdb98e2d47e351919a82d9614db2029 Cr-Commit-Position: refs/heads/master@{#32513}

Patch Set 1 #

Patch Set 2 : fixed missing rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/js/v8natives.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491613002/1
5 years ago (2015-12-01 17:36:51 UTC) #2
Camillo Bruni
PTAL
5 years ago (2015-12-01 17:40:15 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/11466)
5 years ago (2015-12-01 17:58:51 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491613002/1
5 years ago (2015-12-02 09:20:31 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491613002/20001
5 years ago (2015-12-02 09:30:28 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 09:57:13 UTC) #12
neis
lgtm
5 years ago (2015-12-02 10:31:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491613002/20001
5 years ago (2015-12-02 11:16:43 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8397)
5 years ago (2015-12-02 11:21:25 UTC) #17
Camillo Bruni
need owner lgtm.
5 years ago (2015-12-02 12:09:05 UTC) #19
Jakob Kummerow
lgtm
5 years ago (2015-12-02 13:00:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491613002/20001
5 years ago (2015-12-02 13:05:11 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 14:03:33 UTC) #23
commit-bot: I haz the power
5 years ago (2015-12-02 14:03:59 UTC) #25
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/535e221d4fdb98e2d47e351919a82d9614db2029
Cr-Commit-Position: refs/heads/master@{#32513}

Powered by Google App Engine
This is Rietveld 408576698