Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14916006: Merge 149874 "DevTools: Do not unbind stylesheets in multiframe ..." (Closed)

Created:
7 years, 7 months ago by apavlov
Modified:
7 years, 7 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Merge 149874 "DevTools: Do not unbind stylesheets in multiframe ..." > DevTools: Do not unbind stylesheets in multiframe documents > > Stylesheets from top-level document appear as removed if the activeStyleSheetsUpdated() event > comes from an iframe and thus gets unbound. Multiple variations of this issue are possible, > so the originating document should be taken into account to filter the bound stylesheets. > > BUG=238589 > > Review URL: https://chromiumcodereview.appspot.com/14821010 TBR=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -219 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/inspector/styles/resources/stylesheet-tracking.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/inspector/styles/resources/stylesheet-tracking-iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/inspector/styles/resources/stylesheet-tracking-import.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/inspector/styles/resources/stylesheet-tracking-import-1.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/inspector/styles/resources/stylesheet-tracking-import-2.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/inspector/styles/stylesheet-tracking.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/inspector/styles/stylesheet-tracking-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/inspector/styles/resources/stylesheet-tracking.css View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/inspector/styles/stylesheet-tracking.html View 1 chunk +0 lines, -179 lines 0 comments Download
D LayoutTests/inspector/styles/stylesheet-tracking-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
MM Source/core/inspector/InspectorCSSAgent.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 2 chunks +11 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentationInl.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apavlov
7 years, 7 months ago (2013-05-13 05:53:48 UTC) #1
apavlov
7 years, 7 months ago (2013-05-13 06:03:34 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r150194.

Powered by Google App Engine
This is Rietveld 408576698