Issue 14916005: Revert 198382 "Convert a BrowserView.BrowserViewLayout interacti..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14916005: Revert 198382 "Convert a BrowserView.BrowserViewLayout interacti..." (Closed)

Created:
7 years, 7 months ago by James Cook

Modified:
7 years, 7 months ago

Reviewers:
James Cook

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 198382 "Convert a BrowserView.BrowserViewLayout interacti..." > Convert a BrowserView.BrowserViewLayout interactive_uitest to unit_test > > Instantiate the TemplateURLService dependency of BrowserView in unit_test BrowserViewTest to allow it to happen. > > BUG=233374 > TEST=unit_tests, interactive_ui_tests BrowserView* > > Review URL: https://chromiumcodereview.appspot.com/14598011 TBR=jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198474

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -142 lines)			Patch
	M	trunk/src/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc	View		3 chunks	+103 lines, -1 line	0 comments	Download
	M	trunk/src/chrome/browser/ui/views/frame/browser_view_unittest.cc	View		5 chunks	+3 lines, -141 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r198474.