Ctrl+U should show up view-source on Application shortcuts....

Ctrl+U should show up view-source on Application shortcuts.
According to pkasting in dev mailing list:

"Ctrl-U for an application should do what the context menu 
option does: open a source tab in some normal window."

Hence, made it a NEW_FOREGROUND_TAB for disposition

BUG=5115
(http://crbug.com/5115)

[Peter Kasting, 2008-12-20 02:20:29]

LGTM

[Finnur, 2008-12-20 08:20:10]

Same here. LGTM.

[Peter Kasting, 2008-12-22 18:37:54]

I was about to check this in, then I thought about it more and checked the code,
and I realized that we could probably just use the OpenURL() call in all cases,
instead of ever using AddTabWithURL() (whose use I think predates the
WindowOpenDisposition enum).  Can you try this, and if it still works for the
non-app cases, we can check that in instead?

[Mohamed Mansour (USE mhm), 2008-12-22 18:52:56]

On 2008/12/22 18:37:54, pkasting wrote:
> I was about to check this in, then I thought about it more and checked the
code,
> and I realized that we could probably just use the OpenURL() call in all
cases,
> instead of ever using AddTabWithURL() (whose use I think predates the
> WindowOpenDisposition enum).  Can you try this, and if it still works for the
> non-app cases, we can check that in instead?

Sure, once I finish what I am working on now :) I am in a middle of doing
something, give me a couple of minutes.

[Mohamed Mansour (USE mhm), 2008-12-23 05:27:06]

I really don't know what happened to my build, it crashes every time, so I can't
test anything.

Finnur, please revert the commit, until I test it fully with pkasting's
comments.

[Mohamed Mansour (USE mhm), 2008-12-23 06:34:52]

On 2008/12/23 05:27:06, Mohamed Mansour wrote:
> I really don't know what happened to my build, it crashes every time, so I
can't
> test anything.
> 
> Finnur, please revert the commit, until I test it fully with pkasting's
> comments.


Sorry guys, I can't test this bug anymore, due to "always" crashing, until that
bug is fixed, I will continue this one :/

http://crbug.com/5818

[Mohamed Mansour (USE mhm), 2008-12-23 07:21:33]

On 2008/12/22 18:37:54, pkasting wrote:
> I was about to check this in, then I thought about it more and checked the
code,
> and I realized that we could probably just use the OpenURL() call in all
cases,
> instead of ever using AddTabWithURL() (whose use I think predates the
> WindowOpenDisposition enum).  Can you try this, and if it still works for the
> non-app cases, we can check that in instead?

Updated the patch, and tested popup, application, and window and it worked as
you expected.

[Peter Kasting, 2009-01-05 20:15:58]

LGTM, but my computer is pretty hosed so I can't check in soon.  Finnur, can you
check this in?