Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1491593004: Add some more headless API feature placeholders (Closed)

Created:
5 years ago by Sami
Modified:
4 years, 11 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, paulirish
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some more headless API feature placeholders BUG=546953 Committed: https://crrev.com/e630408c584f29a6cb9773d62c8c1224c1d9e5e7 Cr-Commit-Position: refs/heads/master@{#369437}

Patch Set 1 #

Patch Set 2 : Added some more missing bits. #

Total comments: 2

Patch Set 3 : Review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -7 lines) Patch
M headless/public/headless_browser.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M headless/public/web_contents.h View 1 2 chunks +37 lines, -7 lines 0 comments Download
M headless/public/web_frame.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sami
4 years, 11 months ago (2016-01-14 15:52:03 UTC) #3
rmcilroy
LGTM https://codereview.chromium.org/1491593004/diff/20001/headless/public/web_frame.h File headless/public/web_frame.h (right): https://codereview.chromium.org/1491593004/diff/20001/headless/public/web_frame.h#newcode55 headless/public/web_frame.h:55: virtual void SetPageScaleFactor(float) = 0; add a parameter ...
4 years, 11 months ago (2016-01-14 15:56:51 UTC) #4
Sami
Thanks Ross! https://codereview.chromium.org/1491593004/diff/20001/headless/public/web_frame.h File headless/public/web_frame.h (right): https://codereview.chromium.org/1491593004/diff/20001/headless/public/web_frame.h#newcode55 headless/public/web_frame.h:55: virtual void SetPageScaleFactor(float) = 0; On 2016/01/14 ...
4 years, 11 months ago (2016-01-14 16:29:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491593004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491593004/40001
4 years, 11 months ago (2016-01-14 16:32:44 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-14 17:04:30 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 17:05:56 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e630408c584f29a6cb9773d62c8c1224c1d9e5e7
Cr-Commit-Position: refs/heads/master@{#369437}

Powered by Google App Engine
This is Rietveld 408576698