Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 1491573002: Split text related measurements from SVG1DOM counter (Closed)

Created:
5 years ago by davve
Modified:
5 years ago
Reviewers:
Ilya Sherman, fs
CC:
fs, asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split text related measurements from SVG1DOM counter Create a SVG1DOMText UseCounter to measure all text related SVG DOM functionality. The assumption we want to test is that the text related SVG DOM has really low usage. BUG=415074 Committed: https://crrev.com/5907cbe7ccfba7dc541c0f43319f9e44f6c45726 Cr-Commit-Position: refs/heads/master@{#362543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextContentElement.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextPathElement.idl View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextPositioningElement.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491573002/1
5 years ago (2015-12-01 15:05:02 UTC) #2
davve
PTAL
5 years ago (2015-12-01 15:39:14 UTC) #4
fs
lgtm
5 years ago (2015-12-01 15:42:42 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 16:25:22 UTC) #7
Ilya Sherman
lgtm
5 years ago (2015-12-01 22:20:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491573002/1
5 years ago (2015-12-01 22:24:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 23:21:30 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-01 23:23:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5907cbe7ccfba7dc541c0f43319f9e44f6c45726
Cr-Commit-Position: refs/heads/master@{#362543}

Powered by Google App Engine
This is Rietveld 408576698