ui/file_manager/audio_player/elements/audio_player.js - Issue 1491543002: AudioPlayer: Update layout to show the volume slider without using popup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/audio_player/elements/audio_player.js

Issue 1491543002: AudioPlayer: Update layout to show the volume slider without using popup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/audio_player/assets/200/player_button_volume_muted.png ('k') | ui/file_manager/audio_player/elements/control_panel.css » ('j') | ui/file_manager/audio_player/elements/control_panel.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/audio_player/elements/audio_player.js

diff --git a/ui/file_manager/audio_player/elements/audio_player.js b/ui/file_manager/audio_player/elements/audio_player.js

index 6c1820f4ee9cbd9ae441741b481e3f9f4eaf2867..df977197802e974e766f38e9a70b1fa6d24ab454 100644

--- a/ui/file_manager/audio_player/elements/audio_player.js

+++ b/ui/file_manager/audio_player/elements/audio_player.js

@@ -439,22 +439,6 @@ Polymer({

onKeyDown_: function(event) {

switch (event.keyIdentifier) {

- case 'Up':

- if (this.$.audioController.volumeSliderShown && this.model.volume < 100)

- this.model.volume += 1;

- break;

- case 'Down':

- if (this.$.audioController.volumeSliderShown && this.model.volume > 0)

- this.model.volume -= 1;

- break;

- case 'PageUp':

- if (this.$.audioController.volumeSliderShown && this.model.volume < 91)

- this.model.volume += 10;

- break;

- case 'PageDown':

- if (this.$.audioController.volumeSliderShown && this.model.volume > 9)

- this.model.volume -= 10;

- break;

case 'MediaNextTrack':

this.onControllerNextClicked();

break;