Fixes the issue that CharacterComposer always update the composition text (CrOS).

Fixes the issue that CharacterComposer always update the composition text (CrOS).

BUG=260347
TEST=Done manually.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248860

[Yuki, 2014-02-04 09:00:53]

Could you review this CL?
cc'ing to horo just FYI.  Your advice was great.  Thanks.

[Hiro Komatsu, 2014-02-04 09:20:24]

On 2014/02/04 09:00:53, Yuki wrote:
> Could you review this CL?
> cc'ing to horo just FYI.  Your advice was great.  Thanks.

Is it possible to add unittests?

[Yuki, 2014-02-04 09:40:46]

On 2014/02/04 09:20:24, Hiro Komatsu wrote:
> On 2014/02/04 09:00:53, Yuki wrote:
> > Could you review this CL?
> > cc'ing to horo just FYI.  Your advice was great.  Thanks.
> 
> Is it possible to add unittests?

It's not that easy.  We have to create a fake CharacterComposer implementation
and inject it to InputMethodChromeOS.  It means we have to split
CharacterComposer class into the interface class and the concrete class.  I
don't think it's worth doing for this small fix.

[Hiro Komatsu, 2014-02-04 10:44:06]

On 2014/02/04 09:40:46, Yuki wrote:
> On 2014/02/04 09:20:24, Hiro Komatsu wrote:
> > On 2014/02/04 09:00:53, Yuki wrote:
> > > Could you review this CL?
> > > cc'ing to horo just FYI.  Your advice was great.  Thanks.
> > 
> > Is it possible to add unittests?
> 
> It's not that easy.  We have to create a fake CharacterComposer implementation
> and inject it to InputMethodChromeOS.  It means we have to split
> CharacterComposer class into the interface class and the concrete class.  I
> don't think it's worth doing for this small fix.

I see, thanks.

lgtm.

[Yuki, 2014-02-04 13:00:55]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2014-02-04 13:02:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/149153005/1

[commit-bot: I haz the power, 2014-02-04 13:54:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 13:54:33]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[skia-commit-bot, 2014-02-04 13:55:03]

CQ bit was unchecked on CL. Ignoring.

[Yuki, 2014-02-04 14:01:24]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2014-02-04 14:01:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/149153005/1

[commit-bot: I haz the power, 2014-02-04 15:03:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 15:03:10]

Retried try job too often on ios_dbg_simulator for step(s) url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[skia-commit-bot, 2014-02-04 15:03:15]

CQ bit was unchecked on CL. Ignoring.

[Yuki, 2014-02-05 02:42:14]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2014-02-05 03:42:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/149153005/1

[commit-bot: I haz the power, 2014-02-05 05:30:20]

Change committed as 248860