Issue 149153003: Implement a code stub for floating point modulo operation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149153003: Implement a code stub for floating point modulo operation (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 10 months ago

Reviewers:
m.m.capewell, baptiste.afsa1, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/a64

Visibility:
Public.

More Reviews

Description

Implement a code stub for floating point modulo operation BUG=none R=m.m.capewell@googlemail.com, ulan@chromium.org, baptiste.afsa@arm.com LOG=y Committed: https://code.google.com/p/v8/source/detail?r=18982

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
	M	src/a64/code-stubs-a64.cc	View		3 chunks	+16 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

m.m.capewell

Baptiste's unavailable, so I've taken a look instead. LGTM.

6 years, 10 months ago (2014-01-31 10:53:52 UTC) #2

jochen (gone - plz use gerrit)

Committed patchset #1 manually as r18982 (tree was closed).

6 years, 10 months ago (2014-01-31 11:00:29 UTC) #4

ulan

6 years, 10 months ago (2014-01-31 13:06:58 UTC) #5

Message was sent while issue was closed.

On 2014/01/31 11:00:29, jochen wrote:
> Committed patchset #1 manually as r18982 (tree was closed).

Looks like this regressed bunch of tests in debug:

=== cctest/test-api/Threading2 ===
--- stderr ---
abort: lhs has been clobbered.
#
# Fatal error in ../src/frames.cc, line 457
# CHECK(kind == Code::FUNCTION || kind == Code::OPTIMIZED_FUNCTION) failed

Expand Messages | Collapse Messages