Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: runtime/vm/compiler.cc

Issue 1491503003: VM: In CompileAll, don't iterate collected closures for every class (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index 207e0afcc7f7eeaa0516e4fbaeafd85b41609329..124239341455cf53dedd91ca14c4ffd65e18903d 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -1390,24 +1390,6 @@ RawError* Compiler::CompileAllFunctions(const Class& cls) {
func.ClearCode();
}
}
-
- // Inner functions get added to the closures array. As part of compilation
- // more closures can be added to the end of the array. Compile all the
- // closures until we have reached the end of the "worklist".
- const GrowableObjectArray& closures =
- GrowableObjectArray::Handle(zone,
- Isolate::Current()->object_store()->closure_functions());
- for (int i = 0; i < closures.Length(); i++) {
- func ^= closures.At(i);
- if ((func.Owner() == cls.raw()) && !func.HasCode()) {
- error = CompileFunction(thread, func);
- if (!error.IsNull()) {
- return error.raw();
- }
- func.ClearICDataArray();
- func.ClearCode();
- }
- }
return error.raw();
}
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698