VM: In CompileAll, don't iterate collected closures for every class

VM: In CompileAll, don't iterate collected closures for every class

Instead iterate all collected closures at the end. This avoids unnessarily
visiting of the collected closures array and calling Function::Owner.

BUG=
R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/a05ad6111a7fe8e98ee8b713b285458da36b1e55

[Florian Schneider, 2015-12-01 13:25:15]

fschneider@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-12-01 16:57:57]

LGTM with comment.

The only downside I see is that Compiler::CompileAllFunctions(cls) no longer
compiles all functions of the given class. It works for now, because there are
no other callers of this function.

https://codereview.chromium.org/1491503003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1491503003/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:10997: error = cls.EnsureIsFinalized(Thread::Current());
Use thread here.

[Florian Schneider, 2015-12-01 17:04:52]

Yes, that's correct. If we need this functionality we would need a new method.

I changed it for now because Function::Owner() showed up on the profile pretty
high when running the CompileAll benchmarks.

https://codereview.chromium.org/1491503003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1491503003/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:10997: error = cls.EnsureIsFinalized(Thread::Current());
On 2015/12/01 16:57:57, hausner wrote:
> Use thread here.

Done.

[Florian Schneider, 2015-12-01 17:26:37]

Description was changed from

==========
VM: In CompileAll, don't iterate collected closures for every class

Instead iterate all collected closures at the end. This avoids unnessarily
visiting of the collected closures array and calling Function::Owner.

BUG=
==========

to

==========
VM: In CompileAll, don't iterate collected closures for every class

Instead iterate all collected closures at the end. This avoids unnessarily
visiting of the collected closures array and calling Function::Owner.

BUG=
R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a05ad6111a7fe8e98ee8b713b285458da36b1e55
==========

[Florian Schneider, 2015-12-01 17:26:39]

Committed patchset #2 (id:20001) manually as
a05ad6111a7fe8e98ee8b713b285458da36b1e55 (presubmit successful).