Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: net/base/cert_verifier.h

Issue 14915: Move certificate verification off the IO thread.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/cert_status_flags.cc ('k') | net/base/cert_verifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/cert_verifier.h
===================================================================
--- net/base/cert_verifier.h (revision 9082)
+++ net/base/cert_verifier.h (working copy)
@@ -13,6 +13,7 @@
namespace net {
+class CertVerifyResult;
class X509Certificate;
// This class represents the task of verifying a certificate. It can only
@@ -35,9 +36,10 @@
// Verifies the given certificate against the given hostname. Returns OK if
// successful or an error code upon failure.
//
- // The |cert_status| bitmask is always filled out regardless of the return
- // value. If the certificate has multiple errors, the corresponding status
- // flags are set in |cert_status|, and the error code for the most serious
+ // The |*verify_result| structure, including the |verify_result->cert_status|
+ // bitmask, is always filled out regardless of the return value. If the
+ // certificate has multiple errors, the corresponding status flags are set in
+ // |verify_result->cert_status|, and the error code for the most serious
// error is returned.
//
// If |rev_checking_enabled| is true, certificate revocation checking is
@@ -50,7 +52,7 @@
// be passed to the callback when available.
//
int Verify(X509Certificate* cert, const std::string& hostname,
- bool rev_checking_enabled, int* cert_status,
+ bool rev_checking_enabled, CertVerifyResult* verify_result,
CompletionCallback* callback);
private:
« no previous file with comments | « net/base/cert_status_flags.cc ('k') | net/base/cert_verifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698