Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3164)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 1491463002: build CrOS chrome with gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/cros/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index 3eed120832f10c091058706af881c439adc0454c..a7d91acfca613e00c0a924ac1522f50892ebe266 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -181,12 +181,13 @@ if (target_os == "android") {
_default_toolchain = "//build/toolchain/android:$target_cpu"
}
} else if (target_os == "chromeos") {
+ # See comments in build/toolchain/cros/BUILD.gn about board compiles.
assert(host_os == "linux",
"ChromeOS builds are only supported on Linux hosts.")
if (is_clang) {
- _default_toolchain = "//build/toolchain/linux:clang_$target_cpu"
+ _default_toolchain = "//build/toolchain/cros:clang_$target_cpu"
Dirk Pranke 2015/12/02 00:25:17 If someone tries to do a build with target_os="chr
rjkroege 2015/12/03 18:48:59 Done. And verified that (with the right args.gn) t
} else {
- _default_toolchain = "//build/toolchain/linux:$target_cpu"
+ _default_toolchain = "//build/toolchain/cros:$target_cpu"
}
} else if (target_os == "ios") {
_default_toolchain = "//build/toolchain/mac:ios_clang_arm"
« no previous file with comments | « no previous file | build/toolchain/cros/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698