Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Issue 1491453003: Fix Xaos port (Closed)

Created:
5 years ago by Sam Clegg
Modified:
5 years ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Fix Xaos port The Xoas port was rendering only white due to change in the handling of the alpha channel in PP_ImageData. This change sets of alpha channel to 0xff. Other fixes: - better logging system - fix old URLs - fix glibc build by moving to auto-generated nmf Committed: https://chromium.googlesource.com/external/naclports/+/664d91fa17de0e947f00071477ca6e32f4f07f25

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -52 lines) Patch
M ports/xaos/build.sh View 3 chunks +25 lines, -24 lines 0 comments Download
M ports/xaos/nacl-ui-driver/ppapi.c View 6 chunks +14 lines, -3 lines 0 comments Download
M ports/xaos/nacl-ui-driver/ui_nacl.h View 1 chunk +10 lines, -8 lines 0 comments Download
M ports/xaos/nacl-ui-driver/ui_nacl.c View 3 chunks +20 lines, -4 lines 0 comments Download
M ports/xaos/xaos.html View 1 chunk +3 lines, -5 lines 0 comments Download
D ports/xaos/xaos.nmf View 1 1 chunk +0 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Sam Clegg
5 years ago (2015-11-30 23:27:46 UTC) #3
binji
lgtm
5 years ago (2015-12-01 00:19:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491453003/20001
5 years ago (2015-12-01 00:20:18 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-01 00:21:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/naclports/+/664d91fa17de0e947f0007...

Powered by Google App Engine
This is Rietveld 408576698