pkg/compiler/lib/src/js_backend/namer.dart - Issue 1491413008: Canonical output ordering for constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 1491413008: Canonical output ordering for constants. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/namer.dart

diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart

index 768a0726f57d7103af5c9b87bd80c87e884f9c3d..4cd691e63c17c1d1b8415737e6faa7666acbc7fd 100644

--- a/pkg/compiler/lib/src/js_backend/namer.dart

+++ b/pkg/compiler/lib/src/js_backend/namer.dart

@@ -1888,6 +1888,8 @@ class ConstantCanonicalHasher implements ConstantValueVisitor<int, Null> {

@override

int visitDeferred(DeferredConstantValue constant, [_]) {

+ // TODO(sra): Investigate that the use of hashCode here is probably a source

+ // of instability.

int hash = constant.prefix.hashCode;

return _combine(hash, _visit(constant.referenced));

}