GTTF: Convert WebContentsImplBrowserTest to use EmbeddedTestServer.

net/test/embedded_test_server/embedded_test_server.h

Index: net/test/embedded_test_server/embedded_test_server.h
diff --git a/net/test/embedded_test_server/embedded_test_server.h b/net/test/embedded_test_server/embedded_test_server.h
index 7f85374d8b7e1ebcb8b0ddaafd1d88a2882208b7..ba56bcbf874ebf4e283e2e06d2b549742102100f 100644
--- a/net/test/embedded_test_server/embedded_test_server.h
+++ b/net/test/embedded_test_server/embedded_test_server.h
@@ -17,6 +17,10 @@
 #include "googleurl/src/gurl.h"
 #include "net/socket/tcp_listen_socket.h"
 
+namespace base {
+class FilePath;
+}
+
 namespace net {
 namespace test_server {
 
@@ -107,6 +111,11 @@ class EmbeddedTestServer : public StreamListenSocket::Delegate {
   // Returns the port number used by the server.
   int port() const { return port_; }
 
+  // Registers request handler which serves files from |directory|
+  // under PathService path key |root_key|. Returns true on success.
+  bool ServeFilesFromDirectory(

[satorux1, 2013/05/16 04:57:59]

I think we need a unit test for this function. EmbeddedTestServer has good test
coverage, and we should keep it. :)

+      int root_key, const base::FilePath& directory) WARN_UNUSED_RESULT;

[satorux1, 2013/05/16 04:57:59]

I think this function should just take a directory path, so that this function
can be used from places where PathService is not involved.

It's just two lines to resolve the PathService path on the caller side anyway.

+
   // The most general purpose method. Any request processing can be added using
   // this method. Takes ownership of the object. The |callback| is called
   // on UI thread.