Issue 14914008: Fix 64 bit compile errors flagged by conversions from size_t to uint32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14914008: Fix 64 bit compile errors flagged by conversions from size_t to uint32. (Closed)

Created:
7 years, 7 months ago by ananta

Modified:
7 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix 64 bit compile errors flagged by conversions from size_t to uint32. Using static_cast for now. BUG=237249 TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199569

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	webkit/plugins/npapi/plugin_host.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ananta

Committed patchset #1 manually as r199569 (presubmit successful).

7 years, 7 months ago (2013-05-10 23:19:58 UTC) #2

jschuh

7 years, 7 months ago (2013-05-11 18:42:16 UTC) #3

Message was sent while issue was closed.

On 2013/05/10 23:19:58, ananta wrote:
> Committed patchset #1 manually as r199569 (presubmit successful).

Same thing with checked_numeric_cast from base/safe_numerics.h.

Expand Messages | Collapse Messages