Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: sdk/lib/io/http_impl.dart

Issue 14914002: Change fromString constructor to parse static method (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixed additional tests Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/http_headers.dart ('k') | tests/standalone/io/http_auth_digest_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http_impl.dart
diff --git a/sdk/lib/io/http_impl.dart b/sdk/lib/io/http_impl.dart
index 33d8d2405d6d929aaf6a8eab8498959db2f3c711..e3e49450c67280e42e7432e8b3dcd5968faf4cd8 100644
--- a/sdk/lib/io/http_impl.dart
+++ b/sdk/lib/io/http_impl.dart
@@ -291,7 +291,7 @@ class _HttpClientResponse
List<String> challenge = headers[HttpHeaders.WWW_AUTHENTICATE];
assert(challenge != null || challenge.length == 1);
_HeaderValue header =
- new _HeaderValue.fromString(challenge[0], parameterSeparator: ",");
+ _HeaderValue.parse(challenge[0], parameterSeparator: ",");
_AuthenticationScheme scheme =
new _AuthenticationScheme.fromString(header.value);
String realm = header.parameters["realm"];
@@ -371,7 +371,7 @@ class _HttpClientResponse
List<String> challenge = headers[HttpHeaders.PROXY_AUTHENTICATE];
assert(challenge != null || challenge.length == 1);
_HeaderValue header =
- new _HeaderValue.fromString(challenge[0], parameterSeparator: ",");
+ _HeaderValue.parse(challenge[0], parameterSeparator: ",");
_AuthenticationScheme scheme =
new _AuthenticationScheme.fromString(header.value);
String realm = header.parameters["realm"];
@@ -1185,7 +1185,7 @@ class _HttpClientConnection {
var authInfo = incoming.headers["authentication-info"];
if (authInfo != null && authInfo.length == 1) {
var header =
- new _HeaderValue.fromString(
+ _HeaderValue.parse(
authInfo[0], parameterSeparator: ',');
var nextnonce = header.parameters["nextnonce"];
if (nextnonce != null) cr.nonce = nextnonce;
« no previous file with comments | « sdk/lib/io/http_headers.dart ('k') | tests/standalone/io/http_auth_digest_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698