Issue 14914002: Change fromString constructor to parse static method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14914002: Change fromString constructor to parse static method (Closed)

Created:
7 years, 7 months ago by Søren Gjesse

Modified:
7 years, 7 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Change fromString constructor to parse static method on HeaderValue and ContentType. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22406

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -43 lines)			Patch
M	pkg/http/lib/src/request.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/lib/src/response.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/test/multipart_test.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/oauth2/lib/src/handle_access_token_response.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/http.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/http.dart	View		3 chunks	+7 lines, -8 lines	0 comments	Download
M	sdk/lib/io/http_headers.dart	View		3 chunks	+17 lines, -10 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/standalone/io/http_auth_digest_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/http_body_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/io/http_headers_test.dart	View		4 chunks	+12 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Gjesse

7 years, 7 months ago (2013-05-06 07:30:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22406 (presubmit successful).