Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1491393002: Remove unused NTP UMA stats. (Closed)

Created:
5 years ago by newt (away)
Modified:
5 years ago
Reviewers:
Yusuf, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused NTP UMA stats. This deletes four user actions that were added long ago and are no longer used: - MobileFirstEditInOmnibox - MobileFocusedFakeboxOnNtp - MobileFocusedOmniboxOnNtp - MobileFocusedOmniboxNotOnNtp This also starts recording the FocusLocation user action when the omnibox is focused; this essentially combines MobileFocusedFakeboxOnNtp, MobileFocusedOmniboxOnNtp, and MobileFocusedOmniboxNotOnNtp into a single action. BUG=408176 Committed: https://crrev.com/bddb028a3dbf3e8f03b69593e1567235dc7854b7 Cr-Commit-Position: refs/heads/master@{#363041}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -34 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 4 chunks +2 lines, -34 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
newt (away)
PTAL
5 years ago (2015-12-02 23:16:09 UTC) #2
Yusuf
lgtm
5 years ago (2015-12-03 18:28:42 UTC) #3
newt (away)
isherman: PTAL at actions.xml
5 years ago (2015-12-03 18:32:30 UTC) #5
Ilya Sherman
actions.xml lgtm, thank you
5 years ago (2015-12-03 18:35:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491393002/20001
5 years ago (2015-12-03 18:42:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 20:08:59 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-03 20:10:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bddb028a3dbf3e8f03b69593e1567235dc7854b7
Cr-Commit-Position: refs/heads/master@{#363041}

Powered by Google App Engine
This is Rietveld 408576698